~singpolyma/sgx-jmp

sgx-jmp/lib/registration.rb -rw-r--r-- 11.2 KiB
Split CreditCardSale from Transaction

This is a refactor that involves pulling the Credit Card stuff (meaning
braintree) out of the Transaction stuff. This makes Transaction a more
generic implementation of our Transaction table.

This commit should maintain the status quo, though. The places that used
to call Transaction.sale now call CreditCardSale.create, and that got a
little easier because we now do the `.insert` inside the create, because
previously all the callsites just got the transaction out and then
inserted anyway.

So they got a little bit simpler, but the main value of this is that now
we can insert other kinds of transactions and not just credit card
transactions!
Refactor alt top up to use FormTemplate
Better text for when used with webview
Merge branch 'ruby3'

* ruby3:
  Fix for ruby3
  Test on Ubuntu LTS (with ruby3)
  Update to new minitest
Merge branch 'customer_id_in_order'

* customer_id_in_order:
  Include customer id as CustomerOrderId when ordering number
Include customer id as CustomerOrderId when ordering number

So we can tell who ordered a number in case of issues
Merge branch 'prev'

* prev:
  Allow prev from mail-in registration
  Allow prev from invite code
  Allow prev from credit card form
  Make sure OOB comes first in payload
  Allow prev from Bitcoin registration
  Allow prev action on TelSelections search results
Merge branch 'disable-voicemail'

* disable-voicemail:
  Allow infinite timeout / disabled voicemail
Allow infinite timeout / disabled voicemail

Use Forward to hand control completely to the target call.  If something ends up
at our voicemail due to error or similar, just hang up.
Include tel in note for billing transactions
Allow prev from mail-in registration
Allow prev from invite code
Allow prev from credit card form
Make sure OOB comes first in payload
Allow prev from Bitcoin registration
Merge branch 'admin-actions'

* admin-actions:
  Admin Command Flash
  AddInvites Command
  SetTrustLevel Command
  ResetDeclines Command
  Undo and Undoable Command Harness
  Move Cancel and Financial Admin Commands
  AdminAction and AdminActionRepo
  Invites Repo
  Cleanup Admin Form
Invites Repo

In preparation for another command I'd like to make I've first got to
make a place where Invites live.

There's probably other parts of the code that interact with Invites that
I've missed, but this is a good start at least.
Merge branch 'policy'

* policy:
  Show FUP before starting registration in earnest
Show FUP before starting registration in earnest
Next