~singpolyma/sgx-jmp

ref: f571b5e726750cf8c4523c22d77e110194c3e16a sgx-jmp/lib/transaction.rb -rw-r--r-- 2.3 KiB
Merge branch 'credit-card-blacklist'

* credit-card-blacklist:
  Credit card blacklist
Credit card blacklist

Any card on the list is just treated as though it is not present, preventing it
from being used.
Merge branch 'insert-settled-after'

* insert-settled-after:
  Credit card transactions settle after 90 days, bills instantly
Credit card transactions settle after 90 days, bills instantly
Declines should be an Int

Previously this retured a string and everywhere that used it had to
convert it into an it, or handle it if it's nil.

That's dumb.
Now it's always an int, and `nil.to_i` is 0 anyway so I don't have to
check that either.
Merge branch 'tx-list'

* tx-list:
  Admin Command Menu + Admin Financial View
  Transactions List
  Customer Financials
  Telephone Link
Customer Financials

I've pulled out information about payment methods and bitcoin into its
own thing. It's kind of a repository, except that it only exposes
fetchers and doesn't load anything generally.

There's also a few new methods here that aren't used yet, but will be
shortly.
LowBalance returns amount added, if any
Merge branch 'rubocop'

* rubocop:
  Additional fixes for rubocop 1.10.1
  Switch to rubocop 0.89.1
Switch to rubocop 0.89.1

This is the rubocop in new Debian stable
Remove BigDecimal.new

It turns out in newer versions of Ruby this isn't cool anymore.
The new way is BigDecimal(value), which is dumb, but whatever...
It's never been called customer.id
Tell user about bonus amount when doing credit card top up
Merge branch 'credit-card-bonus'

* credit-card-bonus:
  Insert bonus when paying by credit card
Insert bonus when paying by credit card
Refactor BuyAccountCreditForm

add_to_form no longer needs a promise or a network call, instead we use
a factory to get that data up front and inject the dependency.

New BuyAccountCreditForm#parse to get the relevant data back out of an
XMPP form.

Some changes to Transaction and sgx_jmp.rb to use the new method
semantics.
Merge branch 'new-signup-credit-card-decline'

* new-signup-credit-card-decline:
  Block repeated declines for 24 hours
  Handle credit card decline
Block repeated declines for 24 hours
Split logic out into testable objects

Rubocop clean. Good test coverage of helper objects.