LazyObject is not nil, so safenav doesn't work
Merge branch 'tx-list' * tx-list: Admin Command Menu + Admin Financial View Transactions List Customer Financials Telephone Link
Telephone Link Sometimes I need to go there to look something up or change a setting, and every time I do I have to navigate through the UI to a number I already know. This should make that faster.
Merge branch 'overage-limit' * overage-limit: auto_top_up_amount and monthly_overage_limit from CustomerRepo Move Bandwidth Tn remote operations to BandwidthTnRepo Use value_semantics to DRY up CustomerRepo Use NotFound exception for all customer not found cases
auto_top_up_amount and monthly_overage_limit from CustomerRepo Move load of auto_top_up_amount to the repo, and load monthly_overage_limit in the same operation.
Customer Info Forms and More Info There's a bit extra info I wanted about users, so since I was doing this anyway I figured I may as well port the existing forms to the new form renderer. Then, in order to fit within the guidelines I needed subforms, so partials were added.
Make tel present or not more machine readable
Show CNAM in customer info
Merge branch 'rubocop' * rubocop: Additional fixes for rubocop 1.10.1 Switch to rubocop 0.89.1
Switch to rubocop 0.89.1 This is the rubocop in new Debian stable
Move CustomerFwd behind Customer All the previously-lazy BackendSgx data is now either all loaded or all not loaded by swapping the sgx_repo used by your CustomerRepo instance. When not loaded the fields are filled with bottom values that explode when used. When loaded the values are present in RAM and not promises at all. Most code paths do not need any of the data, a few need most of it, so this seems like a good trade-off. Most code using this object will simply never touch those fields or care about how they are loaded, etc. Of course, most of this data isn't even SGX related and should move out of here, but that would take a data model refactor/migration on the catapult_* schema.
Add auto-top-up to customer info report
Even if key catapult_jid- exists, this is bonkers, just say no
Customer Visible Plan Info We moved some of the currently private things to be public, like currency, and then included things like how much the monthly price is as well.
Handle False Registration Turns out my dummy-sgx doesn't act the same as production. Rather than getting a successful registration with no phone, in production I get false, so I need to handle that.
Customer Info This should allow us, the admins, to query information about a customer without having to dive in and run a couple redis queries and some database queries before getting the full picture of who we're talking to. It also allows the users to request some data about themselves. Balance and phone number are already visible in other places, but their expiry is currently not, and people have been asking about it.