~singpolyma/sgx-jmp

ref: 75658ba14b40d551488dae800e9a7d2bfeb239a8 sgx-jmp/lib/transaction.rb -rw-r--r-- 2.2 KiB
Merge branch 'rubocop'

* rubocop:
  Additional fixes for rubocop 1.10.1
  Switch to rubocop 0.89.1
Switch to rubocop 0.89.1

This is the rubocop in new Debian stable
Remove BigDecimal.new

It turns out in newer versions of Ruby this isn't cool anymore.
The new way is BigDecimal(value), which is dumb, but whatever...
It's never been called customer.id
Tell user about bonus amount when doing credit card top up
Merge branch 'credit-card-bonus'

* credit-card-bonus:
  Insert bonus when paying by credit card
Insert bonus when paying by credit card
Refactor BuyAccountCreditForm

add_to_form no longer needs a promise or a network call, instead we use
a factory to get that data up front and inject the dependency.

New BuyAccountCreditForm#parse to get the relevant data back out of an
XMPP form.

Some changes to Transaction and sgx_jmp.rb to use the new method
semantics.
Merge branch 'new-signup-credit-card-decline'

* new-signup-credit-card-decline:
  Block repeated declines for 24 hours
  Handle credit card decline
Block repeated declines for 24 hours
Split logic out into testable objects

Rubocop clean. Good test coverage of helper objects.