~singpolyma/biboumi

e5b392ece8c90605b86d0d93f0ca6989048bc1c3 — louiz’ 7 years ago fca25b7
Fix parse_datetime by always using a 'z' as the timezone

Because some plateform accept Z and z, but some only accept z…
2 files changed, 4 insertions(+), 6 deletions(-)

M louloulibs/utils/time.cpp
M tests/utils.cpp
M louloulibs/utils/time.cpp => louloulibs/utils/time.cpp +2 -1
@@ 14,8 14,9 @@ std::string to_string(const std::time_t& timestamp)

std::time_t parse_datetime(const std::string& stamp)
{
  auto stamp2 = stamp.substr(0, stamp.size() - 1) + "z";
  struct tm tm;
  if (!::strptime(stamp.data(), "%FT%T%Z", &tm))
  if (!::strptime(stamp2.data(), "%FT%T%Z", &tm))
    return -1;
  auto res = ::timegm(&tm);
  return res;

M tests/utils.cpp => tests/utils.cpp +2 -5
@@ 124,10 124,7 @@ TEST_CASE("time_to_string")

TEST_CASE("parse_datetime")
{
  const auto time = utils::parse_datetime("1970-01-01T00:00:00Z");
  CHECK(time == 0);
  CHECK(utils::parse_datetime("2016-08-29T14:29:28Z") == 1472480968);
  CHECK(utils::parse_datetime("2016-08-29T14:29:28UT") == 1472480968);
  CHECK(utils::parse_datetime("2016-08-29T14:29:28GMT") == 1472480968);
  CHECK(utils::parse_datetime("1970-01-01T00:00:00z") == 0);
  CHECK(utils::parse_datetime("2016-08-29T14:29:29Z") == 1472480969);
  CHECK(utils::parse_datetime("blah") == -1);
}
\ No newline at end of file