~singpolyma/biboumi

ccb4ee098f0416ab47a46650705dba6495e8bec7 — louiz’ 5 years ago 5402a25
Apply all the clang-tidy misc-* fixes
M src/irc/iid.cpp => src/irc/iid.cpp +1 -1
@@ 9,7 9,7 @@
constexpr char Iid::separator[];

Iid::Iid(std::string local, std::string server, Iid::Type type):
        type(std::move(type)),
        type(type),
        local(std::move(local)),
        server(std::move(server))
{

M src/irc/irc_client.cpp => src/irc/irc_client.cpp +2 -2
@@ 382,7 382,7 @@ void IrcClient::send_message(IrcMessage&& message)
  std::string res;
  if (!message.prefix.empty())
    res += ":" + std::move(message.prefix) + " ";
  res += std::move(message.command);
  res += message.command;
  for (const std::string& arg: message.arguments)
    {
      if (arg.find(" ") != std::string::npos ||


@@ 889,7 889,7 @@ void IrcClient::on_part(const IrcMessage& message)
        // channel pointer is now invalid
        channel = nullptr;
      }
      this->bridge.send_muc_leave(iid, std::move(nick), std::move(txt), self);
      this->bridge.send_muc_leave(iid, std::move(nick), txt, self);
    }
}


M src/network/credentials_manager.cpp => src/network/credentials_manager.cpp +1 -1
@@ 98,7 98,7 @@ bool BasicCredentialsManager::try_to_open_one_ca_bundle(const std::vector<std::s
              // because the certificate is signed by an issuer that was ignored.
              try {
                  Botan::X509_Certificate cert(bundle);
                  BasicCredentialsManager::certificate_store.add_certificate(std::move(cert));
                  BasicCredentialsManager::certificate_store.add_certificate(cert);
                } catch (const Botan::Decoding_Error& error) {
                  continue;
                }

M src/network/tcp_socket_handler.cpp => src/network/tcp_socket_handler.cpp +0 -1
@@ 42,7 42,6 @@ namespace
using namespace std::string_literals;
using namespace std::chrono_literals;

namespace ph = std::placeholders;

TCPSocketHandler::TCPSocketHandler(std::shared_ptr<Poller>& poller):
  SocketHandler(poller, -1),

M src/utils/timed_events.cpp => src/utils/timed_events.cpp +2 -2
@@ 3,7 3,7 @@

TimedEvent::TimedEvent(std::chrono::steady_clock::time_point&& time_point,
                       std::function<void()> callback, std::string name):
  time_point(std::move(time_point)),
  time_point(time_point),
  callback(std::move(callback)),
  repeat(false),
  repeat_delay(0),


@@ 16,7 16,7 @@ TimedEvent::TimedEvent(std::chrono::milliseconds&& duration,
  time_point(std::chrono::steady_clock::now() + duration),
  callback(std::move(callback)),
  repeat(true),
  repeat_delay(std::move(duration)),
  repeat_delay(duration),
  name(std::move(name))
{
}