~singpolyma/biboumi

142516a69bb000ce80cbb6509d1f407438a94663 — Florent Le Coz 8 years ago 0fcba76
Fix some trivial issues reported by cppcheck
M louloulibs/network/tcp_socket_handler.cpp => louloulibs/network/tcp_socket_handler.cpp +1 -1
@@ 247,7 247,7 @@ void TCPSocketHandler::on_send()
  struct msghdr msg{nullptr, 0,
      msg_iov,
      0, nullptr, 0, 0};
  for (std::string& s: this->out_buf)
  for (const std::string& s: this->out_buf)
    {
      // unconsting the content of s is ok, sendmsg will never modify it
      msg_iov[msg.msg_iovlen].iov_base = const_cast<char*>(s.data());

M src/irc/irc_client.cpp => src/irc/irc_client.cpp +0 -1
@@ 888,7 888,6 @@ void IrcClient::on_unknown_message(const IrcMessage& message)
  if (message.arguments.size() < 2)
    return ;
  std::string from = message.prefix;
  const std::string to = message.arguments[0];
  std::stringstream ss;
  for (auto it = message.arguments.begin() + 1; it != message.arguments.end(); ++it)
    {

M src/xmpp/biboumi_component.cpp => src/xmpp/biboumi_component.cpp +1 -1
@@ 579,7 579,7 @@ void BiboumiComponent::send_ping_request(const std::string& from,
}

void BiboumiComponent::send_iq_room_list_result(const std::string& id,
                                             const std::string to_jid,
                                             const std::string& to_jid,
                                             const std::string& from,
                                             const std::vector<ListElement>& rooms_list)
{

M src/xmpp/biboumi_component.hpp => src/xmpp/biboumi_component.hpp +1 -1
@@ 66,7 66,7 @@ public:
  /**
   * Send the channels list in one big stanza
   */
  void send_iq_room_list_result(const std::string& id, const std::string to_jid,
  void send_iq_room_list_result(const std::string& id, const std::string& to_jid,
                                const std::string& from,
                                const std::vector<ListElement>& rooms_list);
  /**