~singpolyma/biboumi

05a82b810f09d5cf3a0388fc4eeb523d33662c9c — Florent Le Coz 8 years ago 2417688
Display a better error when connection fails

The error should not tell “while reading” when we are just connecting.
1 files changed, 4 insertions(+), 1 deletions(-)

M louloulibs/network/tcp_socket_handler.cpp
M louloulibs/network/tcp_socket_handler.cpp => louloulibs/network/tcp_socket_handler.cpp +4 -1
@@ 266,7 266,10 @@ ssize_t TCPSocketHandler::do_recv(void* recv_buf, const size_t buf_size)
    }
  else if (-1 == size)
    {
      log_warning("Error while reading from socket: " << strerror(errno));
      if (this->connecting)
        log_warning("Error connecting: " << strerror(errno));
      else
        log_warning("Error while reading from socket: " << strerror(errno));
      // Remember if we were connecting, or already connected when this
      // happened, because close() sets this->connecting to false
      const auto were_connecting = this->connecting;